fix(console): Group invite delete button not working #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
added
the
bug
betimshahini
requested changes
Sep 19, 2023
| </section> | ||
|
|
||
| <div className="flex justify-end items-center space-x-3"> | ||
| <Button btnType="secondary-alt">Cancel</Button> |
There was a problem hiding this comment.
Cancel button doesn't appear to cancel the modal.
| <input name="invitationCode" type="hidden" value={invitationCode} /> | ||
| <div className="flex flex-row items-center justify-between w-full mb-2"> | ||
| <Text size="lg" weight="medium" className="text-gray-900"> | ||
| Remove Invitation |
|
|
||
| <section className="mb-4"> | ||
| <Text size="sm" weight="normal" className="text-gray-500 my-3"> | ||
| Are you sure you want to cancel “{userAlias}”'s invitation? |
There was a problem hiding this comment.
"Are you sure you want to cancel the invitation for {userAlias}?"
| <div className="flex justify-end items-center space-x-3"> | ||
| <Button btnType="secondary-alt">Cancel</Button> | ||
| <Button type="submit" btnType="dangerous"> | ||
| Uninvite Member |
| purge?: boolean | ||
| }) => { | ||
| return ( | ||
| <Modal isOpen={isOpen} handleClose={handleClose}> |
There was a problem hiding this comment.
Can we make this the "standard" modal with the X at the top-right to cancel?
|
betimshahini
approved these changes
Sep 19, 2023
betimshahini
deleted the
fix/console/Group-invite-delete-button-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
claimInvitation, nowclearInvitationRelated Issues
Testing
Checklist