Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): Group seats assignment #2701

Merged
merged 5 commits into from
Sep 27, 2023
Merged

feat(console): Group seats assignment #2701

merged 5 commits into from
Sep 27, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Sep 27, 2023 •
edited
Loading

Description

  • Use constant imported from /platform/identity instead of magic number for max free seats
  • Updated seat check to include both free and paid
  • Added colorCode to generic ListItem
image

Related Issues

Testing

  • Filled free group members, notice that add member is disabled
  • Manually remove disabled, try to add member, notice 500 error
  • Remove free-member limit and introduce paid seat extra limit
  • Fill free + paid members, notice that they get colored side-bars, notice that add member is disabled
  • Manually remove disabled, try to add member, notice 500 error

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Sep 27, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Sep 27, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review September 27, 2023 13:01
@betimshahini betimshahini merged commit 8ddf3ee into main Sep 27, 2023
16 of 18 checks passed
@betimshahini betimshahini deleted the feat/console/Group-seats-assignment branch September 27, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(console): Group seats assignment
2 participants
@Cosmin-Parvulescu @betimshahini