Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): improve error handling in node classes #2703

Merged
merged 6 commits into from
Oct 2, 2023
Merged

fix(core): improve error handling in node classes #2703

merged 6 commits into from
Oct 2, 2023

Conversation

szkl
Copy link
Contributor

@szkl szkl commented Oct 1, 2023

Description

Introduces a return type definition for node methods.

The node method callers can utilize getErrorCause utility function
to throw actual errors in the stack.

Removed redundant error handling in the ValidateJWT middleware
function.

The maskError function provided to Yoga sets HTTP status code based
on the RollupError instance.

Related Issues

Testing

  • Manual

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@szkl szkl self-assigned this Oct 1, 2023
@szkl szkl added the bug Indicates an unexpected problem or unintended behavior label Oct 1, 2023
@szkl szkl force-pushed the fix/core/node-method-return-type branch 5 times, most recently from 7acb8c1 to c369ed7 Compare October 2, 2023 12:06
@szkl szkl force-pushed the fix/core/node-method-return-type branch from c369ed7 to ee1f4f1 Compare October 2, 2023 15:31
@betimshahini betimshahini merged commit a545db5 into main Oct 2, 2023
14 checks passed
@betimshahini betimshahini deleted the fix/core/node-method-return-type branch October 2, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

@Cosmin-Parvulescu Cosmin-Parvulescu Awaiting requested review from Cosmin-Parvulescu

Assignees

@szkl szkl

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(galaxy): Errors not propogating to client with Galaxy API Key Invalid
2 participants
@szkl @betimshahini