Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(passport): Passkeys userHandle generation redo #2708

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

betimshahini
Copy link
Contributor

Description

  • Changes passkey identity to be based on a custom userId generated on the server-side, as opposed to the existing method of taking the authenticator credentialId and using that for identifying the account on our system.
  • Adds userId to the challenge, so it can be verified on the server-side during registration.
  • Adds credentialId to the verification process of the passkey authentication, so the credentialId that was provided by authenticator at registration is the same as the one that's providing the assertion now.

Related Issues

Testing

  • Old passkey registrations no longer work
  • Registration of new passkey results in a userId of the format wa_(42 character random hex string) in Passport Settings.
  • Same account & identity is resolved when logging on with the newly-generated passkey subsequently

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@betimshahini betimshahini marked this pull request as ready for review October 5, 2023 11:54
@betimshahini betimshahini changed the title chore(passport): chore(passport): Passkeys userHandle generation redo Oct 5, 2023
@betimshahini betimshahini merged commit f43d794 into main Oct 6, 2023
14 checks passed
@betimshahini betimshahini deleted the chore/2695-passkey-encoding-validation branch October 6, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(passport): Passkeys username encoding & validation
2 participants