feat(console): Disable admin privileges for paid seats on payment failures/stops #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betimshahini
reviewed
Oct 9, 2023
| if (!freeMembers.includes(identityURN)) { | ||
| return { | ||
| error: new UnauthorizedError({ | ||
| message: 'Unauthorized', |
There was a problem hiding this comment.
Make this a bit more descriptive, talking about lack of administrative permissions to change/create/delete.
| if (!members.includes(identityURN)) { | ||
| return { | ||
| error: new UnauthorizedError({ | ||
| message: 'Unauthorized', |
Cosmin-Parvulescu
force-pushed
the
feat/console/Disable-admin-privileges-for-paid-seats-on-payment-failures-stops
branch
from
0a8ebad
to
5870cbd
Compare
betimshahini
requested changes
Oct 10, 2023
| @@ -23,6 +31,21 @@ export const rotateApiKey = async ({ | |||
| `Request received for clientId ${input.clientId} which is not owned by provided account.` | |||
| ) | |||
|
|
|||
| const caller = router.createCaller(ctx) | |||
| const { edges: appOwnershipEdges } = await caller.edges.getEdges({ | |||
| query: { dst: { baseUrn: appURN }, tag: EDGE_APPLICATION }, | |||
There was a problem hiding this comment.
As discussed, pull this out into a function and use where appropriate in the starbase mutation procs.
| throw new UnauthorizedError({ | ||
| message: 'You are not authorized to update this identity group.', | ||
| message: 'You are not authorized to read this identity group.', | ||
| }) | ||
| } |
There was a problem hiding this comment.
Further below, when stripe payer data is updated, even when payment information isn't updated, the flag is being reset and the CTA/warnings for seats needed vs. seats available go away.
| @@ -194,6 +197,21 @@ export default () => { | |||
| ) : null} | |||
| </section> | |||
|
|
|||
| {groupURN && paymentFailedIdentityGroups.includes(groupURN) && ( | |||
There was a problem hiding this comment.
Putting the comment here as reminder: Seat numbers in billing page should be calculated taking into account invited/pending users, not only the ones who have accepted the invitation.
Cosmin-Parvulescu
force-pushed
the
feat/console/Disable-admin-privileges-for-paid-seats-on-payment-failures-stops
branch
2 times, most recently
from
5ea3654
to
0d6fdcf
Compare
Cosmin-Parvulescu
force-pushed
the
feat/console/Disable-admin-privileges-for-paid-seats-on-payment-failures-stops
branch
from
0d6fdcf
to
7e4768a
Compare
betimshahini
approved these changes
Oct 16, 2023
betimshahini
deleted the
feat/console/Disable-admin-privileges-for-paid-seats-on-payment-failures-stops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Testing
Checklist