Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(passport): "Continue with email" submission button below fold on mobile #2714

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(passport): "Continue with email" submission button below fold on mobile #2714

merged 1 commit into from
Oct 11, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Oct 11, 2023 •
edited
Loading

Description

  • Removed flexor element
  • Updated layout to be a simple flex col
  • Fixed email overflow bug

Related Issues

Testing

Deployed to dev and did the flow with my phone.

image
image
image
image

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Oct 11, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Oct 11, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review October 11, 2023 10:08
@szkl szkl merged commit 9bab485 into main Oct 11, 2023
16 of 18 checks passed
@szkl szkl deleted the fix/passport/"Continue-with-email"-submission-button-below-fold-on-mobile branch October 11, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkl szkl szkl approved these changes

@maurerbot maurerbot Awaiting requested review from maurerbot

@betimshahini betimshahini Awaiting requested review from betimshahini

@picassobanana picassobanana Awaiting requested review from picassobanana

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(passport): "Continue with email" submission button below fold on mobile
2 participants
@Cosmin-Parvulescu @szkl