chore(passport|console): Add live preview for Designer #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betimshahini
requested changes
Oct 18, 2023
| @@ -99,8 +102,9 @@ export const loader: LoaderFunction = getRollupReqFunctionErrorWrapper( | |||
|
|
|||
| if (rollup_action && !isSupportedRollupAction(rollup_action)) | |||
| throw new BadRequestError({ | |||
| message: | |||
| 'only Rollup action supported are connect, create, and reconnect ', | |||
| message: `only Rollup action supported are: ${getSupportedRollupActions().join( | |||
There was a problem hiding this comment.
minor nit but should be 'actions'
| message: | ||
| 'only Rollup action supported are connect, create, and reconnect ', | ||
| message: `only Rollup action supported are: ${getSupportedRollupActions().join( | ||
| ', ' |
There was a problem hiding this comment.
Putting this here as a reminder from our chat that preview should (eventually) redirect to authenticate and not the connect flow.
betimshahini
approved these changes
Oct 18, 2023
betimshahini
deleted the
chore/passport|console/Add-live-preview-for-Designer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rollup_action=previewRelated Issues
Testing
Open in new tabChecklist