Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): Group to group app transfers #2723

Merged
merged 13 commits into from
Oct 20, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Oct 19, 2023

Description

  • Added transfer prop to application list item, this is similar to the navigate one;
  • Added lite mode to application list so that we can display applications without the added UI overhead;
  • Replaced specific app list implementation in group details with one that uses the generic app list;
  • Tweaked app list graphics to match member in terms of height and spacing;
  • Added group-app-transfer-info endpoint to be used in fetcher when populating dynamic groups, such as the one in the app transfer screen;
  • Updated transferAppToGroup platform method to work with groups as owners, not just identities;
  • Added extra check when transferring apps that I have admin rights to both the source and destination groups;
  • Implemented app transfer screen per Figma layout.

Related Issues

Testing

Simple account

  1. Create new account
  2. Onboard
  3. Go to application list
  4. Open context menu
  5. Open transfer screen
image

Simple account with group and free app

  1. Create new group
  2. Go to application list
  3. Open context menu
  4. Open transfer screen
image image

Group to group with pro app and billing not set

  1. Upgrade app to PRO tier
  2. Create new group
  3. Go to group details
  4. Open context menu
  5. Open transfer screen
  6. Select newly created group
image

Group to group with pro app, billing set and no entitlements

  1. Set up billing for previously created group
  2. Go to transfer screen
  3. Purchase entitlements
  4. Transfer
image

Group to group with pro app, billing set and entitlements

  1. Buy extra entitlement in destination group
  2. Go to transfer screen
  3. Click transfer, fill modal
image

Group to group with pro app, billing set and no entitlements (3ds)

  1. Create a new group
  2. Fill in billing with a 3ds enabled test card
  3. Go to transfer screen on any PRO app
image

Personal app to group to a group where my admin seat has a failed payment

image

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Oct 19, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Oct 19, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review October 19, 2023 12:47
@betimshahini betimshahini merged commit f8b0b42 into main Oct 20, 2023
16 of 18 checks passed
@betimshahini betimshahini deleted the feat/console/Group-to-group-app-transfers branch October 20, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(console): Group to group app transfers
2 participants