feat(passport): account mask address #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
force-pushed
the
feat/core/email-relay
branch
from
02ea3dc
to
05be9b8
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
3 times, most recently
from
8f37929
to
fe6c321
Compare
szkl
force-pushed
the
feat/core/email-relay
branch
from
05be9b8
to
2da7a83
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
from
fe6c321
to
19514d7
Compare
szkl
force-pushed
the
feat/core/email-relay
branch
from
2da7a83
to
9d15ad5
Compare
| @@ -171,12 +173,14 @@ export const ClaimsMobileView = ({ scopes }: { scopes: any[] }) => { | |||
| const RowView = ({ | |||
| account, | |||
| appAskedFor, | |||
| masked = false, | |||
There was a problem hiding this comment.
This doesn't seem to be used in the mobile view
| @@ -527,15 +532,19 @@ export const ClaimsWideView = ({ scopes }: { scopes: any[] }) => { | |||
| > | |||
| {appAskedFor} | |||
| </Text> | |||
| {masked ? <EmailMaskedPill /> : null} | |||
There was a problem hiding this comment.
For this kind of condition there's also the && pattern: {masked && <EmailMaskedPill />}
| if (!maskEmail) return | ||
| if (selectedEmail?.mask) return | ||
| setMaskEmailCallback() | ||
| }) |
There was a problem hiding this comment.
This should have a dependency array, either an empty one: [] if its intended to run only on component mount, or possibly a [maskEmail, selectedEmail] one if its intended to run when one of the dependencies change.
| }), | ||
| } | ||
|
|
||
| setDataForScopes(newState) |
There was a problem hiding this comment.
This might be a good use case for:
setDataForScopes(prevState => ({ ...prevState, newState }));
| </Pill> | ||
| ) | ||
|
|
||
| export const EmailMaskedPill = () => |
There was a problem hiding this comment.
A more react-ish way would be to do:
export const EmailMaskedPill = () => (
<BaseEmailPill title="Masked" IconComponent={TbShield} />
);
export const EmailUnmaskedPill = () => (
<BaseEmailPill title="Unmasked" IconComponent={TbShieldOff} />
);
9d15ad5
to
90da3ad
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
4 times, most recently
from
706b2ac
to
74f5b9e
Compare
szkl
force-pushed
the
feat/core/email-relay
branch
from
90da3ad
to
6670435
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
from
74f5b9e
to
de3f77b
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
2 times, most recently
from
cb6acf5
to
2e8f8f9
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
7 times, most recently
from
1daa218
to
dbde928
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
from
dbde928
to
e0f5e45
Compare
|
I've addressed most of the comments and only replied to a few. You can take another look. |
szkl
force-pushed
the
feat/passport/account-mask-address
branch
10 times, most recently
from
f090949
to
b4e2566
Compare
|
It is time to bring this home! |
szkl
force-pushed
the
feat/passport/account-mask-address
branch
6 times, most recently
from
25d6a71
to
b596cfe
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
2 times, most recently
from
ab22582
to
ee7e4b7
Compare
3 tasks
szkl
force-pushed
the
feat/passport/account-mask-address
branch
2 times, most recently
from
32ce4ad
to
a5a7a70
Compare
szkl
force-pushed
the
feat/passport/account-mask-address
branch
from
a5a7a70
to
eb79c4a
Compare
betimshahini
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces mask account feature for email account type. The authorization page
has a toggle switch to mask an email account. The same email account is replaced
by the masked account in the connected accounts too. Only masked email account
is set in the authorization persona data. The user can view the source account
of a granted claim to an application in the passport authorization listing.
The mask email account address is generated when user turns on the switch. An
email account gets a designated mask address for each application. The mask
account is associated with the identity of the source account. The mask email
account is not visible to the user except for viewing the authorization claim
data.
Various modules and components has changes to provide functionality for the
complete the feature. This pull request also has some utility improvement
changes.
The removed storybook modules were failing.
Related Issues
Testing
Checklist