Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(passport): Inclusion of magic links for email OTPs #2749

Merged

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Oct 27, 2023

Description

  • Hook into existing mail code verification mechanism and authentication process
  • Update authenticator graphics based on existence of code
  • Implement primary button css for e-mail
  • Add verify anchor to e-mail

Related Issues

Testing

  • Added a console log for magic link, used that to:
  1. Create new account
  2. Connect to existing account
  3. Join a group
  • Manually added bad code to test that verify screen with error is presented
  • Dev deployment & visual check

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Oct 27, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Oct 27, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review November 1, 2023 10:52
}
const isBot =
cfReq.cf &&
cfReq.cf.botManagement.score <= 30 &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this need to be adjusted, based on our convo on confidence of request coming from human?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - quite sure it's automated
99 - quite sure it's human

Wonder what it should be. I tried it on dev with gmail, outlook, iOS web and it seemed to work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we should be safe(r) if we do auto-verification only in the last 10 percent points of confidence of humanness.

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/Inclusion-of-magic-links-for-email-OTPs branch from ce907e7 to 7cb6cd3 Compare November 1, 2023 20:47
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/passport/Inclusion-of-magic-links-for-email-OTPs branch from 7cb6cd3 to 4dc248b Compare November 6, 2023 08:31
@betimshahini betimshahini merged commit 4ffa4ba into main Nov 8, 2023
15 of 16 checks passed
@betimshahini betimshahini deleted the feat/passport/Inclusion-of-magic-links-for-email-OTPs branch November 8, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(passport): Inclusion of magic links for email OTPs
2 participants