fix(ci/cd): 202401111 #2814
Merged
fix(ci/cd): 202401111 #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
added
the
bug
betimshahini
requested changes
Jan 12, 2024
| if (traceparent) { | ||
| const parsedTraceparent = traceparent.split('-') | ||
| console.assert( | ||
| parsedTraceparent.length === 4, | ||
| `traceparent value: ${traceparent}` | ||
| ) | ||
| const [_, traceId, parentId] = parsedTraceparent | ||
| const traceId = parsedTraceparent[1] |
There was a problem hiding this comment.
Is this a personal preference or a linter rule? The deconstructor syntax looks cleaner.
There was a problem hiding this comment.
Linter warning
| @@ -30,12 +31,14 @@ export const getAccountAvatarMethod: GetAccountAvatarMethod = async ({ | |||
| throw new Error('missing address or type') | |||
| } | |||
|
|
|||
| if (!ctx.hashedIdref) { | |||
There was a problem hiding this comment.
This check is already done in the middleware. Shouldn't be repeated here.
There was a problem hiding this comment.
Linter warning for !
| @@ -64,7 +63,11 @@ export const getAccountProfileMethod: GetAccountProfileMethod = async ({ | |||
| if (!nodeClient) | |||
| throw new InternalServerError({ message: 'missing nodeClient' }) | |||
|
|
|||
| return getProfile(ctx, nodeClient, ctx.accountURN!) | |||
| if (!ctx.accountURN) { | |||
There was a problem hiding this comment.
This check is already done in the middleware. Shouldn't be repeated here.
| @@ -119,7 +122,12 @@ async function getProfile( | |||
| case OAuthAccountType.Google: | |||
| return new GoogleAccount(node, ctx.env) | |||
| case OAuthAccountType.Microsoft: | |||
| return new MicrosoftAccount(node, ctx.hashedIdref!, ctx.env) | |||
| if (!ctx.hashedIdref) { | |||
There was a problem hiding this comment.
This check is already done in the middleware. Shouldn't be repeated here.
| @@ -37,6 +37,11 @@ export const acceptIdentityGroupMemberInvitation = async ({ | |||
| message: 'Identity group DO not found', | |||
| }) | |||
| } | |||
| if (!ctx.identityURN) { | |||
There was a problem hiding this comment.
This check is already done in the middleware. Shouldn't be repeated here.
Cosmin-Parvulescu
force-pushed
the
fix/cicd/202401111
branch
from
3968d0c
to
2f94f59
Compare
|
Left only the error fix. |
betimshahini
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various fixes for the error / warnings in our ci/cd pipeline
Checklist