-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): App storage - Service plan usage details #2846
Merged
betimshahini
merged 6 commits into
main
from
feat/console/App-storage---Service-plan-usage-details
Feb 29, 2024
Merged
feat(console): App storage - Service plan usage details #2846
betimshahini
merged 6 commits into
main
from
feat/console/App-storage---Service-plan-usage-details
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Cosmin-Parvulescu
force-pushed
the
feat/console/App-storage---Service-plan-usage-details
branch
from
February 28, 2024 12:21
7a3f8a9
to
b28c9b6
Compare
Base automatically changed from
feat/console/App-storage-billing---auto-top-up
to
main
February 28, 2024 17:50
Cosmin-Parvulescu
force-pushed
the
feat/console/App-storage---Service-plan-usage-details
branch
from
February 28, 2024 19:57
f7a3a15
to
9abe671
Compare
betimshahini
requested changes
Feb 29, 2024
isOpen={isCancelModalOpen} | ||
setIsOpen={setIsCancelModalOpen} | ||
clientID={appDetails.clientId!} | ||
redirectURL={`/apps/${appDetails.clientId}/billing`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace this with a redirect flag, and set the URL only in the back-end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's
Cosmin-Parvulescu
force-pushed
the
feat/console/App-storage---Service-plan-usage-details
branch
from
February 29, 2024 14:44
d7c03c5
to
3c9a218
Compare
betimshahini
approved these changes
Feb 29, 2024
betimshahini
deleted the
feat/console/App-storage---Service-plan-usage-details
branch
February 29, 2024 14:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues