Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): App storage - Service plan usage details #2846

Merged

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Feb 26, 2024

Description

  • Added external app data usage details on app billing page
  • Added fix error out when external data is disabled yet storage page is getting loaded
  • Added redirect flag to Confirm Cancel Modal for external app data

Related Issues

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Feb 26, 2024
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Feb 26, 2024
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as draft February 26, 2024 13:16
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/App-storage---Service-plan-usage-details branch from 7a3f8a9 to b28c9b6 Compare February 28, 2024 12:21
Base automatically changed from feat/console/App-storage-billing---auto-top-up to main February 28, 2024 17:50
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/App-storage---Service-plan-usage-details branch from f7a3a15 to 9abe671 Compare February 28, 2024 19:57
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review February 29, 2024 09:52
isOpen={isCancelModalOpen}
setIsOpen={setIsCancelModalOpen}
clientID={appDetails.clientId!}
redirectURL={`/apps/${appDetails.clientId}/billing`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace this with a redirect flag, and set the URL only in the back-end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/App-storage---Service-plan-usage-details branch from d7c03c5 to 3c9a218 Compare February 29, 2024 14:44
@betimshahini betimshahini merged commit d5025d4 into main Feb 29, 2024
14 checks passed
@betimshahini betimshahini deleted the feat/console/App-storage---Service-plan-usage-details branch February 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(console): App storage - Service plan usage details
2 participants