Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG(3iD): Polish Tracker - Clear account #533

Merged
merged 1 commit into from
Jul 8, 2022
Merged

BUG(3iD): Polish Tracker - Clear account #533

merged 1 commit into from
Jul 8, 2022

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jul 8, 2022 •
edited
Loading

Description

When the user gets to the gate (screen 2C) and clicks "Try Different Wallet" they are sent back to 2A. When they then select Metamask the flow does not re-start. They should be asked to re-connect / re-sign the message.

References #553

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Jul 8, 2022
@Cosmin-Parvulescu Cosmin-Parvulescu added this to the alpha milestone Jul 8, 2022
@Cosmin-Parvulescu Cosmin-Parvulescu requested a review from alfl July 8, 2022 13:58
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jul 8, 2022
@Cosmin-Parvulescu
Copy link
Contributor Author

Implemented with this trick. Disclaimers apply. Accounts are not preserved on coming back, however, I've implemented signature re-requesting.

@Cosmin-Parvulescu Cosmin-Parvulescu changed the title BUG(3iD): Polish Tracker BUG(3iD): Polish Tracker - Clear account Jul 8, 2022
@alfl alfl mentioned this pull request Jul 14, 2022
Closed
5 tasks
@crimeminister crimeminister merged commit e442502 into main Jul 8, 2022
@crimeminister crimeminister deleted the bug/3id/polish-tracker/clear-account branch July 8, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crimeminister crimeminister crimeminister approved these changes

@alfl alfl Awaiting requested review from alfl

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@Cosmin-Parvulescu @crimeminister