-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move EventStoreFactory one namespace level up #69
Comments
@prolic What do you think regarding the namespace name? |
Do you want to put all factories in the service namespace or do you want to
|
Sorry, my description is confusing (wrote it to early in the morning 😄 ) I would like to put all factories in a
|
I am okay with getting rid of the Service\EventStore namespace in favour of only a Service namespace. But I am against the renaming from Service to Factory. |
Oh now I see, I put the EventStore factory into the Stream subnamespace, my bad. I'll provide a fix ;) |
@prolic yeah, I know that Zend puts factories under the Service namespace, but why? A factory is not a service. It provides a service. zend-expressive organizes the factories under a Maybe also a good idea. The problem I have with Service is that I expect real services in this namespace, not only factories. We must use the same namespace for factories in every project. However, if we decide fast I can change service-bus and release a bugfix |
Well, Container then? :-) You decide. |
Why not Factory? |
As I said, you decide, it's probably the most unimportant issue to me ;-) |
naming is important, but not always easy. Ok let's use |
done, see: #73 |
done too, see: prooph/service-bus#62 |
Namespace of EventStoreFactory should only be
Prooph\EventStore\Service
.We should also think up renaming
Service
toFactory
.Putting factories under a
Service
namespace is common practice in ZF2 but maybe this confuses others.The text was updated successfully, but these errors were encountered: