Do not process already process messages with a custom strategy #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunetics
force-pushed
the
fix_invoker
branch
5 times, most recently
from
f4f180b to
afa40e8
Compare
prolic
requested changes
Apr 24, 2017
| @@ -27,6 +27,10 @@ function (ActionEvent $actionEvent): void { | |||
| $message = $actionEvent->getParam(MessageBus::EVENT_PARAM_MESSAGE); | |||
| $handlers = $actionEvent->getParam(EventBus::EVENT_PARAM_EVENT_LISTENERS, []); | |||
|
|
|||
| if ($actionEvent->getParam(MessageBus::EVENT_PARAM_MESSAGE_HANDLED, false)) { | |||
There was a problem hiding this comment.
move this code up, message and handlers don't need to get fetched before this check.
| @@ -30,6 +30,10 @@ function (ActionEvent $actionEvent): void { | |||
|
|
|||
| $deferred = $actionEvent->getParam(QueryBus::EVENT_PARAM_DEFERRED); | |||
|
|
|||
| if ($actionEvent->getParam(MessageBus::EVENT_PARAM_MESSAGE_HANDLED, false)) { | |||
There was a problem hiding this comment.
move this code up, finder, query and deferred don't need to get fetched before this check.
| @@ -26,6 +26,10 @@ function (ActionEvent $actionEvent): void { | |||
| $message = $actionEvent->getParam(MessageBus::EVENT_PARAM_MESSAGE); | |||
There was a problem hiding this comment.
move this code up, message and handlers don't need to get fetched before this check.
prolic
approved these changes
Apr 24, 2017
|
Thanks. Will release new version tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #156
There was no check in the InvokeStrategy if a message was already handled