Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bugs in Event Bus #171

Merged
merged 3 commits into from
Oct 23, 2017
Merged

Fix Bugs in Event Bus #171

merged 3 commits into from
Oct 23, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented Oct 22, 2017 •
edited
Loading

resolves #169

see also https://youtu.be/U01EVU7LTqY
and part2 is here: https://youtu.be/KYQiy_WiyaM

@prolic prolic added the bug label Oct 22, 2017
@prolic prolic requested a review from codeliner October 22, 2017 14:20
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 98.032% when pulling 22e2d2b on event_bus_fixes into a9727d2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 98.211% when pulling 6b3da95 on event_bus_fixes into a9727d2 on master.

yowmamasita
yowmamasita reviewed Oct 22, 2017
View reviewed changes
src/EventBus.php Outdated
@@ -99,4 +121,14 @@ public function disableCollectExceptions(): void
{
$this->collectExceptions = false;
}

public function isCollectingException(): bool
Copy link

@yowmamasita yowmamasita Oct 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isCollectingExceptions (with an s) since the bool value that this is getting is named collectExceptions ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, s is missing

codeliner
codeliner requested changes Oct 22, 2017
View reviewed changes
Copy link
Member

@codeliner codeliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small spelling issue

src/EventBus.php Outdated
@@ -99,4 +121,14 @@ public function disableCollectExceptions(): void
{
$this->collectExceptions = false;
}

public function isCollectingException(): bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, s is missing

@prolic
Copy link
Member Author

prolic commented Oct 23, 2017

done

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 98.211% when pulling 1ed3321 on event_bus_fixes into a9727d2 on master.

@codeliner codeliner merged commit c6dcdb3 into master Oct 23, 2017
@codeliner codeliner deleted the event_bus_fixes branch October 23, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yowmamasita yowmamasita yowmamasita left review comments

@codeliner codeliner codeliner approved these changes

Assignees

@codeliner codeliner

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in OnEventStrategy
4 participants
@prolic @coveralls @yowmamasita @codeliner