improve effects example slightly #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just adds a line to release anything that might be held in a closure by the cleanup function.
benlesh
commented
May 22, 2024
| @@ -86,6 +86,7 @@ export function effect(callback) { | |||
| return () => { | |||
| w.unwatch(computed); | |||
| typeof cleanup === "function" && cleanup(); | |||
| cleanup = undefined; | |||
There was a problem hiding this comment.
Since cleanup can be any arbitrary user-land function reference, and since the returned function here is being sent out to user-land, there's an opportunity for users to accidentally capture resources they meant to clean up in a closure... albeit very unlikely, this one line is a reasonable defense.
EisenbergEffect
approved these changes
May 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds a line to release anything that might be held in a closure by the cleanup function.
Not a big deal.