Turn off minify for release bundle #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Yes, minification in an app concern, not a library one. (Or used traditionally via script tags or esm.sh imports) We can use export conditions to have both, but that's a level of polish i don't think we're ready for. |
NullVoxPopuli
approved these changes
Jun 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite difficult to debug and patch the signal-polyfill package while working on this PR because this package is shipped to npm as a minified bundle. Since this is a not-for-production prototype and debugging/understanding it is one of the main purposes of it right now, maybe it makes sense to switch off minification?
Before:
After:
