Issue with @signal's Cache: computed Instances Sharing the Same Cache

[JuerGenie]

As shown in the screenshots, the computed function is only called when the first instance is created and updated, but not for other instances:

⬆️ All content looks the same (they are the first instance's content).

The issue is caused by the following code:

// file: signal-utils/src/index.ts

function computedDecorator<Value = any>(
  target: () => Value,
  context: ClassGetterDecoratorContext,
): () => Value {
  /* ... */

  let caches = new WeakMap<typeof target, Signal.Computed<Value>>(); // <- caches target to `Computed` instance, not instance.

  return function (this: unknown) {
    let cache = caches.get(target); // <- always gets the same cache regardless of `this`.
    /* ... */
  };
}

This is my solution:

function computedDecorator<Value = any>(
  target: () => Value,
  context: ClassGetterDecoratorContext,
): () => Value {
  /* ... */

  let caches = new WeakMap<typeof target, WeakMap<object, Signal.Computed<Value>>>();

  return function (this: unknown) {
    let cache = caches.get(target);
    if (!cache) {
      cache = new WeakMap();
      caches.set(target, cache);
    }
    let effect = cache.get(this as object);
    if (!effect) {
      effect = new Signal.Computed(() => target.call(this));
      cache.set(this as object, effect);
    }

    return effect.get();
  };
}

It's work for me.

[aomarks]

I can confirm that @JuerGenie's patch above fixed some gnarly bugs I was hitting involving the @signal decorator sharing cached values in very mysterious ways. Thank you!

It would be great to get the fix landed -- @JuerGenie any chance you might send your patch as a PR? :)

[JuerGenie]

I can confirm that @JuerGenie's patch above fixed some gnarly bugs I was hitting involving the @signal decorator sharing cached values in very mysterious ways. Thank you!

It would be great to get the fix landed -- @JuerGenie any chance you might send your patch as a PR? :)

Sure, I'll open a PR later today :D