Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support mark view #103

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: support mark view #103

wants to merge 15 commits into from
+349 −29

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Nov 28, 2024 •
edited
Loading

This PR implements mark view support for core and react.

@ocavue ocavue mentioned this pull request Nov 28, 2024
Closed
@ocavue ocavue requested a review from Saul-Mirone November 28, 2024 12:35
@ocavue ocavue marked this pull request as ready for review November 28, 2024 12:42
Saul-Mirone
Saul-Mirone approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 4, 2024

Open in Stackblitz

@prosemirror-adapter/core

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/core@103

@prosemirror-adapter/lit

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/lit@103

@prosemirror-adapter/react

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/react@103

@prosemirror-adapter/solid

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/solid@103

@prosemirror-adapter/vue

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/vue@103

@prosemirror-adapter/svelte

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/svelte@103

commit: 06ded44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocavue @Saul-Mirone