Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Update to finapi v1.107 #331

Merged
merged 5 commits into from
Jul 26, 2020
Merged

Update to finapi v1.107 #331

merged 5 commits into from
Jul 26, 2020

Conversation

ccostin93
Copy link
Collaborator

No description provided.

@ccostin93 ccostin93 self-assigned this Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #331 into master will increase coverage by 1.04%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #331      +/-   ##
============================================
+ Coverage     82.82%   83.86%   +1.04%     
- Complexity      966      992      +26     
============================================
  Files           169      170       +1     
  Lines          2533     2548      +15     
  Branches         21       21              
============================================
+ Hits           2098     2137      +39     
+ Misses          416      392      -24     
  Partials         19       19              
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/proshin/finapi/bank/Bank.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/org/proshin/finapi/bank/out/BankInterface.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../tppcredential/in/EditTppCredentialParameters.java 36.36% <0.00%> (-3.64%) 4.00 <0.00> (ø)
src/main/java/org/proshin/finapi/bank/FpBank.java 100.00% <100.00%> (ø) 22.00 <1.00> (+1.00)
.../java/org/proshin/finapi/bank/out/FpBankGroup.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...a/org/proshin/finapi/bank/out/FpBankInterface.java 100.00% <100.00%> (+18.75%) 12.00 <1.00> (+4.00)
.../bankconnection/out/FpBankConnectionInterface.java 100.00% <100.00%> (+100.00%) 9.00 <2.00> (+9.00)
...org/proshin/finapi/client/out/FpConfiguration.java 95.83% <100.00%> (+8.87%) 20.00 <1.00> (+3.00)
...ppcredential/in/CreateTppCredentialParameters.java 100.00% <100.00%> (ø) 9.00 <1.00> (+1.00)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2bb0d...5adc94a. Read the comment docs.

@ccostin93 ccostin93 requested a review from proshin-roman July 23, 2020 23:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@proshin-roman proshin-roman merged commit 53901d6 into master Jul 26, 2020
@proshin-roman proshin-roman deleted the update-to-finapi-v1.107 branch July 26, 2020 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants