Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

#362: Double escaping of query parameters #372

Merged
merged 1 commit into from
Feb 18, 2021
Merged

#362: Double escaping of query parameters #372

merged 1 commit into from
Feb 18, 2021

Conversation

proshin-roman
Copy link
Owner

As the underlying HTTP client already does escaping of query parameters, it's not required to have QueryParamEncodedPair anymore. Instead, I've renamed it to PlainNameValuePair that doesn't do any escaping anymore.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #372 (77ef134) into master (a322379) will not change coverage.
The diff coverage is 92.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #372   +/-   ##
=========================================
  Coverage     83.94%   83.94%           
  Complexity     1043     1043           
=========================================
  Files           176      176           
  Lines          2572     2572           
  Branches         20       20           
=========================================
  Hits           2159     2159           
  Misses          395      395           
  Partials         18       18           
Impacted Files Coverage Δ Complexity Δ
.../java/org/proshin/finapi/mandator/FpIbanRules.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/org/proshin/finapi/mandator/FpKeywordRules.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/org/proshin/finapi/user/FpUsers.java 100.00% <ø> (ø) 11.00 <0.00> (ø)
...ntial/in/QueryTppAuthenticationGroupsCriteria.java 60.00% <40.00%> (ø) 4.00 <1.00> (ø)
.../tppcredential/in/QueryTppCredentialsCriteria.java 81.81% <66.66%> (ø) 4.00 <1.00> (ø)
.../org/proshin/finapi/mandator/in/UsersCriteria.java 94.87% <93.33%> (ø) 18.00 <12.00> (ø)
...oshin/finapi/account/in/DailyBalancesCriteria.java 100.00% <100.00%> (ø) 10.00 <5.00> (ø)
...org/proshin/finapi/account/in/FpQueryCriteria.java 100.00% <100.00%> (ø) 11.00 <5.00> (ø)
...java/org/proshin/finapi/bank/in/BanksCriteria.java 92.85% <100.00%> (ø) 13.00 <8.00> (ø)
.../proshin/finapi/category/in/CashFlowsCriteria.java 100.00% <100.00%> (ø) 22.00 <17.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a322379...77ef134. Read the comment docs.

@proshin-roman proshin-roman merged commit 823465b into master Feb 18, 2021
@proshin-roman proshin-roman deleted the 362 branch February 18, 2021 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant