Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test dirs #1088

Merged
merged 13 commits into from
Mar 7, 2024
Merged

Rename test dirs #1088

merged 13 commits into from
Mar 7, 2024

Conversation

goastler
Copy link
Member

@goastler goastler commented Mar 7, 2024

__tests__ is jest convention. We should use this as it integrates nicely with tools, and I need the tests to be in a well defined place to ignore them with typedoc

fixes prosopo/captcha-private#655

@prosoponator prosoponator enabled auto-merge (squash) March 7, 2024 11:23
@goastler goastler mentioned this pull request Mar 7, 2024
@goastler goastler marked this pull request as draft March 7, 2024 14:00
auto-merge was automatically disabled March 7, 2024 14:00

Pull request was converted to draft

@goastler goastler marked this pull request as ready for review March 7, 2024 14:41
@goastler goastler marked this pull request as draft March 7, 2024 14:41
@goastler goastler marked this pull request as ready for review March 7, 2024 14:50
@goastler
Copy link
Member Author

goastler commented Mar 7, 2024

This no longer renames the tests dir as no longer needed elsewhere. Instead, this moves the output of the test results to avoid git / watching tools from picking up changes to the src

  • introduces a cache dir for us to use

@forgetso forgetso merged commit e370aff into main Mar 7, 2024
9 checks passed
@forgetso forgetso deleted the rename-test-dirs branch March 7, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants