Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procaptcha common #1110

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Procaptcha common #1110

merged 10 commits into from
Mar 19, 2024

Conversation

forgetso
Copy link
Member

@forgetso forgetso commented Mar 19, 2024

I've made a start on de-duplicating the procaptcha stuff and moved all procaptcha types into the types package.

  • This allows us to de-duplicate a bunch of types.
  • The state is now defined in procaptcha-common, which has the knock-on effect of requiring an interface for various classes in types

As it stands, we don't have any functionality that appends a payload to the result of a PoW captcha and this PR will allow me to develop that next (e.g. there is currently no server verification for Frictionless or Pow).

packages/procaptcha-common/src/events.ts Outdated Show resolved Hide resolved
packages/procaptcha-common/src/state.ts Outdated Show resolved Hide resolved
packages/procaptcha/src/modules/Manager.ts Outdated Show resolved Hide resolved
@prosoponator prosoponator merged commit a072113 into main Mar 19, 2024
8 checks passed
@prosoponator prosoponator deleted the procaptcha-common branch March 19, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants