Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox ID and margin fixes #1152

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Checkbox ID and margin fixes #1152

merged 1 commit into from
Apr 17, 2024

Conversation

forgetso
Copy link
Member

@forgetso forgetso commented Apr 17, 2024 •
edited
Loading

  • Add proper random ID to checkbox
  • Use id for label instead of name - using name is wrong. This fix is for screen readers.
  • Fix checkbox and label margins and position

Fixed

image

Currently Live

image

@forgetso
Add proper random ID to checkbox, use id for label instead of name, a…
3ff2dec 
…nd fix checkbox and label margins and position
@prosoponator prosoponator enabled auto-merge (squash) April 17, 2024 09:53
@prosoponator prosoponator merged commit 84041f7 into main Apr 17, 2024
9 checks passed
@prosoponator prosoponator deleted the fix-checkbox-margin-and-id branch April 17, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goastler goastler goastler approved these changes

@HughParry HughParry Awaiting requested review from HughParry HughParry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forgetso @goastler @prosoponator