Fix provider mock #1187
Merged
Fix provider mock #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
forgetso
commented
Apr 26, 2024
•
forgetso
commented
- Fixes for out of date provider mock
- Build and test provider mock on PR
- Build and push provider mock on publish for AMD64
- Adds option to pass gas increase factor when dry running a contract method
- Uses an SVG for the provider GUI header logo
HughParry
reviewed
May 6, 2024
HughParry
reviewed
May 6, 2024
| // The block at which the captcha was requested | ||
| [ApiParams.blockNumber]: number | ||
| [ApiParams.blockNumber]?: number |
There was a problem hiding this comment.
Why would the block at which the captcha was requested not be included in the image verification response?
HughParry
reviewed
May 6, 2024
HughParry
reviewed
May 6, 2024
| ): ContractOptions { | ||
| const gasIncreaseFactor = increaseGas ? GAS_INCREASE_FACTOR : 1 | ||
| gasIncreaseFactor = increaseGas ? (gasIncreaseFactor ? gasIncreaseFactor : GAS_INCREASE_FACTOR) : 1 |
There was a problem hiding this comment.
Suggested change
| gasIncreaseFactor = increaseGas ? (gasIncreaseFactor ? gasIncreaseFactor : GAS_INCREASE_FACTOR) : 1 | |
| gasIncreaseFactor = increaseGas ? gasIncreaseFactor || GAS_INCREASE_FACTOR : 1 |
HughParry
added a commit
that referenced
this pull request
May 15, 2024
This reverts commit e19b3ef.
HughParry
added a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.