Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change callback and elementId to element #1192

Merged
merged 5 commits into from
May 1, 2024

Conversation

Vengi717
Copy link
Contributor

No description provided.

demos/client-bundle-example/src/jsBundleTest.html Outdated Show resolved Hide resolved
packages/procaptcha-bundle/src/index.tsx Outdated Show resolved Hide resolved
packages/procaptcha-bundle/src/index.tsx Outdated Show resolved Hide resolved
packages/procaptcha-bundle/src/index.tsx Outdated Show resolved Hide resolved
packages/procaptcha-bundle/src/index.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@forgetso forgetso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of extra comments from me.

demos/client-bundle-example/src/jsBundleTest.html Outdated Show resolved Hide resolved
demos/client-bundle-example/src/jsBundleTest.html Outdated Show resolved Hide resolved
packages/procaptcha-bundle/package.json Show resolved Hide resolved
@Vengi717 Vengi717 requested a review from forgetso May 1, 2024 08:28
Copy link
Member

@forgetso forgetso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added

Copy link
Member

@forgetso forgetso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@forgetso forgetso dismissed stale reviews from HughParry and goastler May 1, 2024 09:40

all points addressed

@prosoponator prosoponator merged commit 7493e22 into main May 1, 2024
10 checks passed
@prosoponator prosoponator deleted the 1131-change-callback-element branch May 1, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants