Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick lint #1238

Merged
merged 12 commits into from
May 22, 2024
Merged

Quick lint #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
58f371f
add readmes, code of conduct and diagram to lint ignore file
goastler May 21, 2024
78cc720
lint only files which have changed
goastler May 21, 2024
db99476
add license linting back in
goastler May 21, 2024
2a92304
typo
goastler May 21, 2024
9373362
reorder args
goastler May 21, 2024
d91f77b
debug files
goastler May 21, 2024
0f648ba
missing line
goastler May 21, 2024
a25f871
rearrange args for eslint and prettier
goastler May 21, 2024
88d814b
remove quiet parameter from eslint
goastler May 21, 2024
e94d38a
lint
goastler May 21, 2024
e7a6f54
add eslintignore file to eslintignore file
goastler May 21, 2024
c9eb453
Merge branch 'main' into quick-lint
goastler May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
**/*bundle*.js

Check warning on line 1 in .eslintignore

View workflow job for this annotation

GitHub Actions / check 

File ignored by default.
**/ProcaptchaWidget-*.js
**/index-*.js
**/typechain/*
Expand Down Expand Up @@ -42,3 +42,8 @@
.env.*
**/assets/*.js
*.min.js
**/Readme.md
**/README.md
code-of-conduct.md
diagram.svg
**/.eslintignore
16 changes: 14 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,18 @@ jobs:

- run: npm ci

- run: npm run build -w @prosopo/scripts
- run: npm run -w @prosopo/scripts build

- run: npm run lint
- name: license
run: npm run -w @prosopo/scripts license

- name: lint
run: |
# get the files which have changed in the PR
files=$(curl -L -s -H "Authorization: Bearer ${{ github.token }}" -H "Accept: application/vnd.github.v3+json" "${{ github.event.pull_request.url }}/files" | jq -r '.[] | .filename')

echo "files: $files"

# feed those files into eslint + prettier, as we only need to lint the files that have changed
npx eslint --ignore-path .eslintignore --no-error-on-unmatched-pattern -- $files
npx prettier --check --ignore-path .eslintignore --no-error-on-unmatched-pattern -- $files
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"test": "npm run --workspaces test",
"test:all": "npm run --workspaces --if-present test",
"eslint": "npm --workspaces run eslint && npm run eslint:workspace",
"eslint:workspace": "npx eslint '.*.*' '*.*' .vscode .github --ignore-pattern README.md --ignore-pattern code-of-conduct.md --ignore-pattern diagram.svg --ignore-path .eslintignore --quiet",
"eslint:workspace": "npx eslint '.*.*' '*.*' .vscode .github --ignore-path .eslintignore --quiet",
"eslint:contracts": "npm -w @prosopo/captcha-contract -w @prosopo/common-contract -w @prosopo/proxy-contract run eslint",
"eslint:fix": "npm --workspaces run eslint:fix && npm run eslint:fix:workspace",
"eslint:fix:workspace": "npm run eslint:workspace -- --fix",
Expand Down
Loading