Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm script workspaces fail fast #1249

Merged
merged 4 commits into from
May 27, 2024
Merged

Conversation

goastler
Copy link
Member

@goastler goastler commented May 24, 2024

  • make script to go through workspace members and run a command, failing immediately upon error
  • make build:all and test:all scripts fail immediately on error
  • make lint commands use fail-fast workspace command to exit immediately upon error

This is because npm --workspaces doesn't fail the command until the very end, even if the error happens at the first workspace

@prosoponator prosoponator enabled auto-merge (squash) May 24, 2024 15:57
@prosoponator prosoponator merged commit a6e18d4 into main May 27, 2024
8 checks passed
@prosoponator prosoponator deleted the npm-script-workspaces-fail-fast branch May 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants