use gh cli for publishing releases to gh

[goastler]

fixes prosopo/captcha-private#749

[goastler]

blocked by #878

[pr-explainer-bot]

Pull Request Review Markdown

Hey there! 👋 Here's a summary of the previous results for the pull request review. Let's dive in!

Changes

1. Major changes are not mentioned in the provided code snippet.

Suggestions

• In line 19, instead of using npm i -g npm@$(cat package.json | jq -r .engines.npm), it would be better to use npm install -g npm@$(cat package.json | jq -r .engines.npm) for better readability.
• In line 35, instead of using NEXT_MAJOR=$(echo $NEXT | cut -d '.' -f 1), it would be better to use NEXT_MAJOR=${NEXT%%.*} for better readability.
• In line 36, instead of using NEXT_MINOR=$(echo $NEXT | cut -d '.' -f 2), it would be better to use NEXT_MINOR=${NEXT#*.} for better readability.
• In line 37, instead of using NEXT_PATCH=$(echo $NEXT | cut -d '.' -f 3), it would be better to use NEXT_PATCH=${NEXT##*.} for better readability.
• In line 38, instead of using CURRENT_MAJOR=$(echo $CURRENT | cut -d '.' -f 1), it would be better to use CURRENT_MAJOR=${CURRENT%%.*} for better readability.
• In line 39, instead of using CURRENT_MINOR=$(echo $CURRENT | cut -d '.' -f 2), it would be better to use CURRENT_MINOR=${CURRENT#*.} for better readability.
• In line 40, instead of using CURRENT_PATCH=$(echo $CURRENT | cut -d '.' -f 3), it would be better to use CURRENT_PATCH=${CURRENT##*.} for better readability.

Bugs

There are no potential bugs mentioned in the provided code snippet.

Improvements

One place in the code that could be refactored for better readability is in line 35-40. Instead of using multiple cut commands to extract the major, minor, and patch versions, you can use parameter expansion to achieve the same result in a more concise way. Here's the refactored code snippet:

NEXT_MAJOR=${NEXT%%.*}
NEXT_MINOR=${NEXT#*.}
NEXT_MINOR=${NEXT_MINOR%%.*}
NEXT_PATCH=${NEXT##*.}
CURRENT_MAJOR=${CURRENT%%.*}
CURRENT_MINOR=${CURRENT#*.}
CURRENT_MINOR=${CURRENT_MINOR%%.*}
CURRENT_PATCH=${CURRENT##*.}

This refactoring simplifies the code and makes it easier to understand.

Rating

I would rate the code 7.5 out of 10. The code has good readability overall, but there are some areas where it can be improved. The performance seems to be fine, as there are no obvious bottlenecks or inefficiencies. In terms of security, it's difficult to assess without more context about the code's purpose and potential vulnerabilities.

That's it for the summary! If you have any questions or need further clarification, feel free to reach out. Happy reviewing! 😄

---

Note: Some changes and suggestions were not included due to the size of the pull request. Please refer to the commit history for a complete overview.