Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cache restore step from post_pr workflow #894

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

goastler
Copy link
Member

@goastler goastler commented Dec 8, 2023

this stops the cache bloating due to old rust crates sitting around in the cache. Instead of using the cache, we build from scratch after a PR. This will take a bit longer, but will make the cache only contain files relevant to the current PR build rather than all PRs in the whole history

Copy link

Pull Request Report

Hey there! 👋 Here's the report for the changes made in this pull request:

Changes

  1. Removed the cache restore step from the post_pr workflow.

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

No improvements suggested.

Rating

I would rate the code as follows:

  • Readability: 8/10
  • Performance: 9/10
  • Security: 9/10

Great job overall! If you have any questions or need further assistance, feel free to ask. Keep up the good work! 🎉

@forgetso forgetso enabled auto-merge (squash) December 8, 2023 09:41
@forgetso forgetso merged commit 7046345 into main Dec 8, 2023
5 checks passed
@forgetso forgetso deleted the 893-fix-gha-cache-bloat branch December 8, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants