Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

895 fix bump version workflow not compiling typechain properly #896

Merged

Conversation

goastler
Copy link
Member

@goastler goastler commented Dec 8, 2023

No description provided.

Copy link

Pull Request Report

Greetings! 👋

Here's a summary of the changes made in this pull request:


Changes

  1. Added a build step for @prosopo/protocol-dev in the Build job. (Line 57)

Suggestions

No suggestions at the moment.


Bugs

No bugs found.


Improvements

No improvements suggested.


Rating

I would rate the code as follows:

  • Readability: 8/10
  • Performance: 9/10
  • Security: 9/10

The code is generally readable, performs well, and appears to have good security practices in place.


That's all for now! Let me know if you need any further assistance. 😄

@goastler goastler enabled auto-merge (squash) December 8, 2023 09:49
@goastler goastler merged commit 3d76226 into main Dec 8, 2023
5 checks passed
@goastler goastler deleted the 895-fix-bump_version-workflow-not-compiling-typechain-properly branch December 8, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants