Type aware linting

[goastler]

fixes prosopo/captcha-private#442

blocked by #904

[pr-explainer-bot]

Pull Request Report

Hey there! I've prepared a report for the pull request. Let's dive in!

Changes

1. Moved file extensions to eslint config.
2. Moved eslint config to esm format.
3. Moved back to cjs format.
4. Removed eslint-plugin-prettier.
5. Started eslint config from scratch.
6. Reconfigured eslint config.
7. Removed typed linting from eslint.
8. Linted the code.
9. Added type support to eslint.

Suggestions

• Line 5: Consider removing the eslint:recommended from the extends array since it is duplicated later.
• Line 14: Instead of disabling the no-unused-vars rule with 'no-unused-vars': 'off', you can remove it from the rules object.
• Line 19: The prettier plugin should be added to the extends array instead of the plugins array.
• Line 23: The root property is set to true, but it's not necessary since the .eslintrc.cjs file is already at the root of the project.

Bugs

• File .eslintrc.cjs: Line 5, Column 20: The node property is missing a closing brace }.

Improvements

Here's a place in the code that could be refactored for better readability:

In .eslintrc.cjs, lines 5-8:

module.exports = {
  node: true,
  // ...
};

This can be simplified to:

module.exports = {
  env: {
    node: true,
  },
  // ...
};

Rating

I would rate the code a 7 out of 10 based on the following criteria:

• Readability: The code is generally readable, but there are some areas that could be improved.
• Performance: It's difficult to assess performance without more context, but there don't seem to be any obvious performance issues.
• Security: Again, without more context, it's hard to evaluate security, but there don't appear to be any glaring security concerns.

That's it for the report! Let me know if you need any further assistance. Happy coding!

[github-actions]

⏳ Blocked by: * #904.
🔔 I'll update this comment when the blocking issues/PRs are closed.
💭 From Dependent Issues (:robot:)

[goastler]

closing in favour of #909