Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nvmrc #918

Merged
merged 7 commits into from
Dec 13, 2023
Merged

use nvmrc #918

merged 7 commits into from
Dec 13, 2023

Conversation

goastler
Copy link
Member

No description provided.

Copy link

Pull Request Report

Hey there! Here's a report on the changes made in the pull request:

Changes

  1. Updated the node-version to use the value from the .nvmrc file instead of a hardcoded value in the following workflows:
    • .github/workflows/bump_version.yml
    • .github/workflows/clippy.yml
    • .github/workflows/contract_version.yml
    • .github/workflows/lint.yml
    • .github/workflows/ls_cache.yml
    • .github/workflows/post_pr.yml
    • .github/workflows/provider_image.yml
    • .github/workflows/publish.yml
    • .github/workflows/rustfmt.yml
    • .github/workflows/tests.yml
    • .github/workflows/tests_protocol.yml

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

No improvements suggested.

Rating

I would rate the code a solid 8 out of 10. The code is readable, performs well, and seems secure.

That's it for the report! Let me know if you need anything else. Cheers!

@goastler goastler enabled auto-merge (squash) December 13, 2023 13:36
@goastler goastler merged commit dc46694 into main Dec 13, 2023
10 checks passed
@goastler goastler deleted the nvmrc branch December 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants