Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check version publish workflow #923

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

goastler
Copy link
Member

No description provided.

Copy link

Pull Request Report

Greetings! 👋

Here's a summary of the changes, suggestions, bugs, improvements, and rating for this pull request.

Changes

  1. Remove quotes from current version parsing. (Line 29)

    • Code: NEXT=$(npm pkg get version | tr -d '"')
  2. Fix version comparison if check. (Line 57)

    • Code:
      if [[ "$NEXT_MAJOR" -gt "$CURRENT_MAJOR" ]]; then
          echo "major version bump detected"
          echo "bump=true" >> $GITHUB_OUTPUT
      elif [[ "$NEXT_MINOR" -gt "$CURRENT_MINOR" ]]; then
          echo "minor version bump detected"
          echo "bump=true" >> $GITHUB_OUTPUT
      elif [[ "$NEXT_PATCH" -gt "$CURRENT_PATCH" ]]; then
          echo "patch version bump detected"
          echo "bump=true" >> $GITHUB_OUTPUT
      else

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

No improvements suggested.

Rating

I would rate the code as follows:

  • Readability: 8/10
  • Performance: 9/10
  • Security: 7/10

That's all for now! Let me know if you need any further assistance. 😄

@goastler goastler merged commit 4cbdd38 into main Dec 21, 2023
5 checks passed
@goastler goastler deleted the fix-check-version-publish-workflow branch December 21, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants