Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip steps if no version bump in publish workflow #925

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

goastler
Copy link
Member

No description provided.

Copy link

Pull Request Report

Greetings! 👋

Here's a report for the changes made in the pull request:

Changes:

  1. Numbered list with major changes:
    • ...

Suggestions:

  1. Suggestions to improve code. Point to specific lines:
    • ...

Bugs:

  1. Places with potential bugs. Point to specific files:
    • ...

Improvements:

  1. Find 1-2 places in the code that could be refactored for better readability. Rewrite it to improve and provide code snippet. Point to specific file:
    • ...

Rating:

Rate the code from 0 to 10 based on the following criteria: readability, performance, security. Explain briefly:

  • Readability: ...
  • Performance: ...
  • Security: ...

Code Highlights:

--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -78,19 +78,26 @@ jobs: 
             # setup node
             - uses: actions/setup-node@v3
+              if: steps.check_version.outputs.bump == 'true'
               with:
                   node-version-file: '.nvmrc'
             - name: Install npm
+              if: steps.check_version.outputs.bump == 'true'
               run: npm i -g npm@$(cat package.json | jq -r .engines.npm)
 
             # get the latest build from the cache produced in the post_pr workflow
 
             - run: mkdir -p protocol/cargo-cache
+              if: steps.check_version.outputs.bump == 'true'
             - run: mkdir -p protocol/target
+              if: steps.check_version.outputs.bump == 'true'
             - run: mkdir -p node_modules
+              if: steps.check_version.outputs.bump == 'true'
             - run: mkdir -p ~/.cache/Cypress
+              if: steps.check_version.outputs.bump == 'true'
 
             - name: Restore cache
+              if: steps.check_version.outputs.bump == 'true'
               uses: actions/cache/restore@v3
               with:
                   path: |@@ -106,9 +113,13 @@ jobs:                       project-cache-${{ runner.os }}-${{ runner.arch }}-
 
             - run: ls -la ~/.cache/Cypress || true
+              if: steps.check_version.outputs.bump == 'true'
             - run: ls -la protocol/cargo-cache || true
+              if: steps.check_version.outputs.bump == 'true'
             - run: ls -la protocol/target/ink || true
+              if: steps.check_version.outputs.bump == 'true'
             - run: ls -la node_modules || true
+              if: steps.check_version.outputs.bump == 'true'
 
             - name: Install
               if: steps.check_version.outputs.bump == 'true'

That's it for the report! Let me know if you need anything else. 😄

@goastler goastler merged commit 8c5694e into main Dec 21, 2023
4 checks passed
@goastler goastler deleted the early-abandon-publish-workflow branch December 21, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants