Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.20 #929

Merged
merged 5 commits into from
Jan 4, 2024
Merged

0.2.20 #929

merged 5 commits into from
Jan 4, 2024

Conversation

forgetso
Copy link
Member

@forgetso forgetso commented Jan 4, 2024

No description provided.

Copy link

Pull Request Review - Summary

Hey there! 👋 Here's a summary of the previous tasks and their results for the pull request review:

Changes

  1. Updated version in contracts/captcha/package.json from 0.2.19 to 0.2.20
  2. Updated version in contracts/common/package.json from 0.2.19 to 0.2.20
  3. Updated version in contracts/proxy/package.json from 0.2.19 to 0.2.20
  4. Updated version in demos/client-bundle-example/package.json from 0.2.19 to 0.2.20
  5. Updated version in demos/client-example-server/package.json from 0.2.19 to 0.2.20
  6. Updated version in demos/client-example/package.json from 0.2.19 to 0.2.20
  7. Updated version in demos/cypress-shared/package.json from 0.2.19 to 0.2.20
  8. Updated version in demos/dapp-example/contracts/Cargo.toml from 0.2.19 to 0.2.20
  9. Updated version in demos/provider-mock/package.json from 0.2.19 to 0.2.20
  10. Updated version in dev/config/package.json from 0.2.19 to 0.2.20
  11. Updated version in package.json from 0.2.19 to 0.2.20
  12. Updated version in packages/file-server/package.json from 0.2.19 to 0.2.20

Suggestions

  1. In demos/client-example/package.json, consider using a consistent version for all @prosopo dependencies. Currently, some dependencies have version 0.2.20 while others have 0.2.19.

Bugs

  1. In packages/api/src/api/ProviderApi.ts, there is a potential bug in the 'getCaptchaChallenge' method. The 'userAccount' parameter is currently of type 'string', but it should be of type 'AccountId' to match the type used in other methods.

Improvements

  1. In packages/api/src/api/ProviderApi.ts, consider using a more descriptive name for the 'userAccount' parameter in the 'getCaptchaChallenge' method.
  2. In packages/api/src/api/ProviderApi.ts, consider using a more descriptive name for the 'userAccount' parameter in the 'submitCaptchaSolution' method.
  3. In packages/api/src/api/ProviderApi.ts, consider using a more descriptive name for the 'userAccount' parameter in the 'verifyDappUser' method.
  4. In packages/api/src/api/ProviderApi.ts, consider using a more descriptive name for the 'accountId' parameter in the 'submitUserEvents' method.

Rating

Please rate the code from 0 to 10 based on the following criteria:

  • Readability
  • Performance
  • Security

Feel free to provide a brief explanation for your rating.

That's it for the summary! Let me know if you need any further assistance. 😄

@forgetso forgetso enabled auto-merge (squash) January 4, 2024 11:50
@forgetso forgetso merged commit 465bbf7 into main Jan 4, 2024
11 checks passed
@forgetso forgetso deleted the 0.2.20 branch January 4, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants