Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add echos to publish workflow #943

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Conversation

goastler
Copy link
Member

No description provided.

Copy link

Pull Request Report

Hey there! 👋 Here's a report for the changes made in the pull request:

Changes

  1. Refactored the publish workflow into granular version checks.
  2. Fixed references to the next version variable.
  3. Performed linting.
  4. Added bump echos for publishing.

Suggestions

Unfortunately, there are no specific suggestions provided in the pull request. 😕

Bugs

No bugs have been identified in the code. 🐛

Improvements

  1. The code could be refactored for better readability in a few places:

    • In the .github/workflows/publish.yml file, lines 188-193 could be simplified by using a switch statement instead of multiple if-else conditions. Here's an example:
    case "${{ steps.check_version_github.outputs.bump }}" in
      'true')
        echo "bump=true" >> $GITHUB_OUTPUT
        echo "github bump required"
        ;;
      'true')
        echo "bump=true" >> $GITHUB_OUTPUT
        echo "npm bump required"
        ;;
      'true')
        echo "bump=true" >> $GITHUB_OUTPUT
        echo "docker js_server bump required"
        ;;
      'true')
        echo "bump=true" >> $GITHUB_OUTPUT
        echo "docker provider bump required"
        ;;
      *)
        echo "bump=false" >> $GITHUB_OUTPUT
        echo "no bump required"
        ;;
    esac

Rating

Based on the criteria of readability, performance, and security, I would rate the code a solid 8 out of 10. It's well-structured, efficient, and doesn't seem to have any major security vulnerabilities.

That's it for the pull request report! Let me know if you need any further assistance. 😄

@goastler goastler merged commit e05c390 into main Jan 11, 2024
5 checks passed
@goastler goastler deleted the improve-publish-version-checks branch January 11, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants