Provider admin api with signing

[HughParry]

No description provided.

[pr-explainer-bot]

Pull Request Review - Summary

Hey there! 👋 Here's a summary of the previous tasks and their results for the pull request review:

Changes

1. In funds.ts file, the transfer function was changed to transferAllowDeath at line 73.

Suggestions

1. In funds.ts file, consider providing a comment explaining the reason for using transferAllowDeath instead of transfer at line 73.
2. In start.ts file, the import statement for prosopoAdminRouter was added. Consider organizing the import statements alphabetically for better readability at line 16.

Bugs

1. In funds.ts file, there is a potential bug in the sendFunds function. The resolve and reject functions are not called inside the signAndSend callback. This may cause the promise to never resolve or reject.
2. In start.ts file, the handleErrors function is referenced but not defined. This may cause an error at runtime.

Improvements

1. Refactoring suggestion in start.ts file:

import { prosopoAdminRouter, prosopoRouter } from '@prosopo/provider';

const router = express.Router();

router.use(prosopoRouter(env));
router.use(prosopoAdminRouter(env));

apiApp.use(router);

This refactoring separates the router setup into a separate router variable, making it more readable and modular.

Rating

• Overall Rating: 7.5/10
• Readability: 8/10
• Performance: 7/10
• Security: 7/10

The code overall is readable, but there are some areas that could be improved. Performance and security seem to be average.

Feel free to check the detailed results for more information. Let me know if you need any further assistance! 😄

[forgetso]

On track for world domination. Good work. One small Q. We can handle the commit stuff later when the populator is working.