Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vscode formater and updated docs. #166

Merged
merged 1 commit into from
May 29, 2016
Merged

Added vscode formater and updated docs. #166

merged 1 commit into from
May 29, 2016

Conversation

lfrodrigues
Copy link
Contributor

Added new vscode formater that will be used by prospector plugin in vscode python extension.

Updated docs related to vscode and my old xunit formater

@carlio carlio merged commit b822989 into prospector-dev:master May 29, 2016
@carlio
Copy link
Contributor

carlio commented May 29, 2016

Cheers, will get this into next release once I'm done going through all the open issues 👍

@carlio
Copy link
Contributor

carlio commented May 29, 2016

@lfrodrigues is this line correct?

template = '%(line)s,%(character)s,%(code)s,%(code)s:%(source)s %(message)s'

It duplicates the code, so error messages end up like

1,0,unused-import,unused-import:pylint Unused defaultdict imported from collections

unused-import is in that line twice. I have no idea about vscode so dunno if that is correct or not.

@lfrodrigues
Copy link
Contributor Author

I built the vscode for this also: DonJayamanne/pythonVSCode#130

It was designed like that because vscode expects to have:

const REGEX = '(?<line>\\d+),(?<column>\\d+),(?<type>[\\w-]+),(?<code>[\\w-]+):(?<message>.*)\\r?(\\n|$)';

From what I understood type was not available in prospector so I coded it like this. Ideally in type we should output something like the "category" in pylint. Is there a simple way to get that?

@carlio
Copy link
Contributor

carlio commented May 31, 2016

@lfrodrigues there isn't really a "type" value from any of the tools, unfortunately. I suppose you could use the source value instead but if it's fine as it is I will leave it alone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants