Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid path bug fix #109

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Invalid path bug fix #109

merged 1 commit into from
Feb 27, 2024

Conversation

swashko
Copy link
Collaborator

@swashko swashko commented Feb 27, 2024 •
edited
Loading

Error handling for invalid path was passing in Path the module instead of path the variable

@swashko swashko self-assigned this Feb 27, 2024
willarmiros
willarmiros approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swashko swashko merged commit 752557e into main Feb 27, 2024
8 checks passed
@swashko swashko deleted the path-bug-fix branch February 27, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willarmiros willarmiros willarmiros approved these changes

@mehrinkiani mehrinkiani Awaiting requested review from mehrinkiani

Assignees

@swashko swashko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swashko @willarmiros