Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize reporting and add CLI options for JSON or custom #81

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

swashko
Copy link
Collaborator

@swashko swashko commented Jan 13, 2024

Modularizes Report class and adds JSONReport child
Adds CLI option for JSON reporting with the option for an output file
Adds CLI option for custom reporting defined through the settings toml file
closes #57

modelscan/cli.py Outdated Show resolved Hide resolved
modelscan/cli.py Outdated Show resolved Hide resolved
modelscan/cli.py Outdated Show resolved Hide resolved
modelscan/cli.py Outdated Show resolved Hide resolved
modelscan/settings.py Outdated Show resolved Hide resolved
modelscan/settings.py Outdated Show resolved Hide resolved
@swashko swashko requested a review from seanpmorgan January 16, 2024 20:39
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, thanks!

modelscan/cli.py Show resolved Hide resolved
@swashko swashko requested a review from seanpmorgan January 17, 2024 18:33
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@seanpmorgan seanpmorgan merged commit 3ea3473 into main Jan 17, 2024
8 checks passed
@seanpmorgan seanpmorgan deleted the modular-reporting branch January 17, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor with modular reporting
2 participants