Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable drag and drop in hierarchies #347

Closed
matthewhorridge opened this issue Mar 4, 2016 · 4 comments
Closed

Add an option to disable drag and drop in hierarchies #347

matthewhorridge opened this issue Mar 4, 2016 · 4 comments

Comments

@matthewhorridge
Copy link
Contributor

No description provided.

matthewhorridge added a commit that referenced this issue Mar 5, 2016
@bdionne
Copy link
Contributor

bdionne commented Mar 6, 2016

This works well.

I'm wondering if an alternative approach would be to add support to OWLModelManagerTree for disabling drag/drop. That way subclasses could disable it without disabling it everywhere else. I know NCI wants it disabled in the navigation pane of EditTab but certain power users are going to be allowed to use the other tabs like the classes tab and we could leave it enabled there. @fragosog may have an opinion on this.

@matthewhorridge
Copy link
Contributor Author

Re-opening as the requirement is that drag should be possible but drop should not be possible

@bdionne
Copy link
Contributor

bdionne commented Mar 8, 2016

thanks @matthewhorridge - this works ok, but there is an edge case that fails. Drag/Drop within the classes tree sometimes acts like a copy rather than a move. Debugging it reveals that the remove axiom fails here:
https://github.com/owlcs/owlapi/blob/version4/impl/src/main/java/uk/ac/manchester/cs/owl/owlapi/Internals.java#L678

Try moving EpithellialCell in this small example:

https://github.com/bdionne/nci-edit-tab/blob/master/samples/owl2-test-cases-Defined-Annotated.owl

@matthewhorridge
Copy link
Contributor Author

Ah, I see what the problem is. EpithelialCell has axiom annotations. When the remove takes place it tries to remove the axiom without annotations and this axiom doesn't exist in the ontology, so the remove fails.

I'm going to open a new issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants