Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem displaying Unicode characters in Protege look-and-feel #714

Closed
swartik opened this issue Sep 22, 2017 · 11 comments
Closed

Problem displaying Unicode characters in Protege look-and-feel #714

swartik opened this issue Sep 22, 2017 · 11 comments
Labels
Status: Fixed Added to indicate that a closed issue represents a bug that has been fixed

Comments

@swartik
Copy link

swartik commented Sep 22, 2017

I have an ontology with class names that contain the fi and ffi ligatures. When the look-and-feel is set to Protege, these ligatures aren't always displayed properly. I am running Windows 7, Java 8 (1.8.0_144). Csongor Nyulas has tested the ontology on Ubuntu and didn't observe the erroneous display, so the problem must be Windows-specific.

I wanted to illustrate the problem by uploading an image, but github wouldn't let me. In the protege-dev mailing list (September 2017), see the thread with the subject "Question on Protege's Unicode character rendering".

@ykazakov
Copy link
Contributor

I have uploaded your screenshot. Strange that github does not let you do this.

unnamed

@swartik
Copy link
Author

swartik commented Sep 22, 2017

Thank you. My company's firewall may well have something to do with the upload failure.

Here's the description I'd wanted to write. In the screenshot, the class name appears in two places: in the hierarchy, and in the label above the hierarchy. The first place displays it correctly, but in the label the "ffi" ligature appears as an empty rectangle.

@csnyulas
Copy link
Member

Here is the whole thread on the mailing list, which provides more details:
http://protege-project.136.n4.nabble.com/Question-on-Protege-s-Unicode-character-rendering-td4669584.html

@matthewhorridge
Copy link
Contributor

Possibly related to #818. @swartik if you have time please could you check to see if this problem is still exhibited in 5.5.0-beta-8?

@matthewhorridge matthewhorridge added the Status: Waiting for Feedback Indicates that the person who is working on the issue needs feedback from someone else label Jan 15, 2019
@swartik
Copy link
Author

swartik commented Jan 18, 2019

A problem remains, unfortunately. Except it's not quite the same. Here's a screenshot from 5.5.0-beta-8:

ligatures-in-550b8

Now the only correctly displayed name is under the ontology selector.

@matthewhorridge
Copy link
Contributor

Thanks a lot @swartik. Hmmm okay. I changed the font for the render to use the font that JTextArea uses to be sure it was on the platform. Previously, it was Verdana, but on Windows this doesn't include some unicode characters that are needed for Chinese. The breadcrumb trail is actually, "Dialog", Plain, 11, which I think maps to Arial on Windows, as far as I can tell.

@matthewhorridge matthewhorridge added this to the Protégé 5.5.0 milestone Jan 18, 2019
@matthewhorridge
Copy link
Contributor

@swartik I've fixed the rendering problem in the class hierarch, I think (for the next beta). However, do the boxes show in the view title if the Look & Feel is set to the Windows Look & Feel?

matthewhorridge added a commit that referenced this issue Jan 19, 2019
@swartik
Copy link
Author

swartik commented Jan 23, 2019

@matthewhorridge Here's the Windows Look & Feel screenshot. The two text strings on the right are correct. The only place I see a problem is in the class hierarchy.
windows-lf
Thanks for dealing with this annoyance. I'll stay tuned for the next beta.

@matthewhorridge
Copy link
Contributor

Thanks a lot @swartik

I think we've finally nailed down the problem. If you have a moment, please could you try the beta-9 snapshot build? It's here:

https://oss.sonatype.org/content/repositories/snapshots/edu/stanford/protege/protege-desktop/5.5.0-beta-9-SNAPSHOT/protege-desktop-5.5.0-beta-9-20190123.010908-11-platform-independent.zip

It's a bare bones build, i.e. no plugins.

@swartik
Copy link
Author

swartik commented Jan 23, 2019

@matthewhorridge Good work. I downloaded the snapshot build and verified that the ligature characters display correctly in all 3 look-and-feels.

@matthewhorridge
Copy link
Contributor

@swartik thanks so much for testing this. Really glad to hear that it works with all L&F. I'll mark this as fixed and close the issue.

@matthewhorridge matthewhorridge added Status: Fixed Added to indicate that a closed issue represents a bug that has been fixed and removed Status: Waiting for Feedback Indicates that the person who is working on the issue needs feedback from someone else labels Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Fixed Added to indicate that a closed issue represents a bug that has been fixed
Projects
None yet
Development

No branches or pull requests

4 participants