-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DOI and WikipediaVersioned Extractor #1049
Add DOI and WikipediaVersioned Extractor #1049
Conversation
Have you tested this or just guessed it from the source code? Can we add OMIM, OMIMPS, DOI, ORCID? Or better yet, add support for an external prefix map? |
@matentzn guess it lol - I can try building it, but currently don't have eclipse installed, and not sure even if I did I really know how to handle stuff. Was mostly doing this cause I had some free time and thought I'd try to take some workload off @hkir-dev (was hoping there was already mapping, but after search realised it was this way, so while I was at it, thought I'd do these changes following pattern, hence really needing proper looking over).
100% would be keen for this, but it might be beyond my skillset |
Good progress @shawntanzk . Seems we need to fix the doi regex (though seems it is a little difficult to have a perfectly working one). We can work and test together. @matentzn providing an external map might be the ultimate solution, but it will require a lot of changes (config menu updates, config file validation and processing etc.) It would be good to go iteratively and have a first version with the current design. |
Sound good @hkir-dev, can you perhaps add then OMIM, OMIMPS, DOI, ORCID, Orphanet? This would make some of our powerusers very happy! |
Unit and manual tests completed, new extractors are working as expected. |
But observed a malfunction in the already existing OboFoundryLinkExtractor. I suspect about the order of IdentifiersDotOrgLinkExtractor and OboFoundryLinkExtractor but seems this order changed intentionally: dd514de Independent from the current PR, obo link extraction requires further analysis and a separate bug report. |
Thanks @hkir-dev, see you cleaned up some of my silly mistakes too heh, thanks heaps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent @hkir-dev! Looks great!
This is a great contribution! Thanks very much @shawntanzk. We really appreciate it! |
Adding DOI and WikipediaVersioned (two things used quite often in a few of the obo foundry ontologies)
Followed patterns from searching repo - probably needs a proper looking over to make sure I didn't do anything stupid.
Tagging @hkir-dev & @matentzn
Related to obophenotype/uberon#1874