Add explanation preferences menu and extension point #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new tab "Explanations" in Preferences, in which explanation preferences will be shown using a new extension point explanationpreferences. Each (explanation) plugin can provide an extension to this extension point, in which case the preferences of this plugin will be shown as a tab in the Explanations tab. Otherwise, to provide preferences the plugin would need to extend the preferences extension point, which would make the general preference menu too crowded. In this way, explanation preferences reflect the logic of explanation plugins.
This adds a simple "General" tab to the "Explanations" tab in Preferences, which list the currently installed explanation services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new explanation preferences menu tab so that explanation plugins can put their preferences under it. This is managed by providing an extension point explanationpreferences.
By default, the explanation preferences menu has just one tab "General" which lists all installed explanation services.