Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird visual glitches when using emacs server. #13

Closed
tusharhero opened this issue Apr 26, 2024 · 21 comments
Closed

Weird visual glitches when using emacs server. #13

tusharhero opened this issue Apr 26, 2024 · 21 comments

Comments

@tusharhero
Copy link

Hey @protesilaos, thank you for this amazing package.

Problem happens only when using emacs server and it doesn't occur when I start emacs without running a server.

Screenshots

image

Specifications

  • GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0)
  • Archlinux (I use the Guix package manager for Emacs.).
  • KDE Plasma 6 Wayland.
@protesilaos
Copy link
Owner

protesilaos commented Apr 26, 2024 via email

@tusharhero
Copy link
Author

I use this command to run the emacsclient with a server: emacsclient -nc -a ''
And this command to just run emacs: emacs

@protesilaos
Copy link
Owner

Does this issue go away if you re-enable spacious-padding-mode? Or is something else involved that sets the :box attribute of the mode line?

I notice that the box does not come directly from the theme (which looks like modus-operandi-deuteranopia) because the theme would/should set a colour for the box. Whereas here we only have a box without an explicit colour, so we see each block extend its own colour to the box (see the -22 and the date).

@tusharhero
Copy link
Author

tusharhero commented Apr 27, 2024

It does go away if I re-enable spacious-padding-mode. I am not sure if something else is involved but here is a relevant portion of my init.el

  (setq custom-safe-themes t)
  (advice-add 'load-theme
              :before (lambda (theme &optional no-confirm no-enable)
                        (disable-theme (car custom-enabled-themes))))

The theme I am using is ef-frost.

@protesilaos
Copy link
Owner

protesilaos commented Apr 27, 2024 via email

@tusharhero
Copy link
Author

Spacious padding is enabled before I load the theme.

@protesilaos
Copy link
Owner

protesilaos commented Apr 27, 2024 via email

@tusharhero
Copy link
Author

I tried changing the order, it doesn't seem to change much.

@nuthub
Copy link

nuthub commented Apr 28, 2024

In my *Messages* I see:

Unable to load color "unspecified-bg"

I'm also using modus-operandi.

Does this issue go away if you re-enable spacious-padding-mode? Or is something else involved that sets the :box attribute of the mode line?

For me disabling and enabling spacious-padding-mode works around that issue. This issue also only occurs when running emacs --daemon and then opening an emacsclient.

@protesilaos
Copy link
Owner

protesilaos commented Apr 29, 2024 via email

protesilaos added a commit that referenced this issue Apr 29, 2024
This is an attempt to fix the common problem of spacious-padding not
getting the correct colours at startup when Emacs runs as a daemon.

Thanks to tusharhero and Julian Flake for reporting on this in issue 13:
<#13>.
@protesilaos
Copy link
Owner

I just added a change. Please let me know if this works for you.

@tusharhero
Copy link
Author

Hey @protesilaos, unfortunately your fix doesn't seem to work for me.

@tusharhero
Copy link
Author

tusharhero commented Apr 29, 2024

I just noticed that creating a new frame by running emacsclient -nc -a '' fixes it. But it doesn't work the first time I run emacsclient -nc -a ''.

The first time I run emacsclient -nc -a'', it starts the emacs server if its not running. I think that may have something to do with it.

@nuthub
Copy link

nuthub commented Apr 29, 2024

Also not fixed for me. I start emacs exactly like tusharhero, but it doesn't make a difference, if I start emacs --daemon and emacsclient -nc separately instead.

@nuthub
Copy link

nuthub commented Apr 29, 2024

Ah, opening a second frame then fixes the glitch with both frames (which is new behaviour, if I remember correctly)!

@tusharhero
Copy link
Author

Ah, opening a second frame then fixes the glitch with both frames (which is new behaviour, if I remember correctly)!

Yup, even I noticed this.

protesilaos added a commit that referenced this issue Apr 29, 2024
@protesilaos
Copy link
Owner

I pushed another change. Can you please try again?

@protesilaos
Copy link
Owner

This is what I get.

Screenshot from 2024-04-29 09-42-26

@nuthub
Copy link

nuthub commented Apr 29, 2024

fixed with af8030e ! 🥳 Thank You!

@tusharhero
Copy link
Author

Fixed for me too!

@protesilaos
Copy link
Owner

Very well! I am waiting for another issue and will then prepare the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants