Allow specifying 0 padding for mode-line, header-line, etc. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thank you! |
protesilaos
added a commit
that referenced
this pull request
Mar 11, 2024
The change was done in pull request 7: <#7>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, attempting to set any key of
spacious-padding-widthsthat usesspacious-padding-set-face-box-padding(eg.:mode-line-width,:header-line-width) in box width calculations to 0 results in an error similar to the following:This is because 0 is an invalid value for
:line-widthin a face's:box. This PR adds a check to see if the specified padding width is 0 before adding the box, and only adds the box if the width is not 0 (if the specified width is 0, then the box is unnecessary, since no padding needs to be added).