Remove zkProgrammable (rebased) WIP #256
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejMina226
changed the title
ejMina226
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of o1js includes the ability to mock a zkProgram. This was the original motivation behind the zkProgrammable abstract class and so it can be removed. This PR includes the following:
Upgrade o1js to version 2.
Fix the types that have changed because of this.
Remove zkProgrammable and WithZkProgrammable and use zkProgramFactory and WithZkProgram
Note
Special attention should be paid to the
SettlementProvingTask.tsTODO:
Rebase onto #258 and see if tests pass. This will make sure that the underlying branch has zero broken tests so any further tests that are broken must have come from these changes.