feat: add feature resolution for protobuf editions #2029
Conversation
src/object.js
Outdated
| var newValue = opt[name]; | ||
| util.setProperty(newValue, propName, value); | ||
| util.setProperty(newValue, propName, value, isFeature); |
There was a problem hiding this comment.
typo, the regex is only wrong if name is the fully feature path. If it's always just features, this will overwrite the entire features object for each specified feature right? It'll only keep the last one?
| message Message { | ||
| option features.json_format = LEGACY_BEST_EFFORT; | ||
| oneof SomeOneOf { | ||
| int32 a = 13; |
There was a problem hiding this comment.
you can put features in oneofs (same syntax as for message), do those work?
There was a problem hiding this comment.
Following the pattern of your other tests, I'd expect these two tests to be collapsed into one that tests both inheritance and overriding of message -> oneof
There was a problem hiding this comment.
isn't that tested in the test below? (feature resolution inheritance oneofs)
There was a problem hiding this comment.
Kindof, it's not clear why this one is split into two when all of the other ones test both things in a single test
There was a problem hiding this comment.
ok I merged it into one test!
No description provided.